11
« on: 20 March, 2007, 11:21:17 AM »
Okay my thanks go to funt for taking the time to make this post, so I will take the time to answer each of his questions. First though let me explain that this is NOT the final submisssion of the site! I want to get all the major bugs ironed out of the code before I do the polishing!
Secondly, the main thrust of the module is to use advanced design techniques to build the site. Whilst it is important to have a nicely laid out site this wasn't my main concern. Since I have had a lot of time constraints I purchased the template from a site and reconfigured it to my needs, hence the reason for a couple of quirks in the HTML. This might sound cheating but it has been documented and also I use Smarty templating, so it was also an exercise in showing how to reconfigure someone else's templates.
1. >>When I passed your site through the w3c validation service I got 4 errors. (I find the quickest way to do this these days is to use the Firefox Web Developer Toolbar.) The errors themselves seem fairly straightforward, so I won't go into them.>Running the CSS through validation, it can't find the sheet called layout.css (it says). I am curious, looking at your code, as to why you've linked to default.css using the link element in the head, and also linked to layout.css, but using the embedded style element and @import. Why not be consistent? >Also, your title element and both the meta elements in the head of your home page (I haven't checked the others) are blank. On purpose?>Blank alt attributes on your images isn't helping out the visually impaired. It takes a few seconds to type in a value there.>box2, box4 etc. are poorly descriptive. Give them a name that also provides meaning. I think the term is meta-structural. (Oh, and you've used box4 twice, which is a no-no for an id attribute.)>Loads of stuff in the table element at the bottom of the page could be done with CSS equivalents, thus cleaning up your xhtml. I'd remove border, width, all the aligns. Even the highlight class could be replaced with a colgroup and attached CSS styling.>It's , not . That single space before the / is important. (Something to do with older browsers.)>The indentation is a mess, although I don't know what the php source file looks like, so perhaps that's partly to blame. >Strikes me that you might be suffering slightly from div-itis, but then at least it's not a table-based layout. A couple of inline styles have snuck into the code near the end - considering how well you've done prior to that to separate structure from presentation, you could ship those off to the css file.